Fix incorrect platform detection in setenvvar.bat on VS2022#8866
Open
tomneko wants to merge 1 commit intoFirebirdSQL:B3_0_Releasefrom
Open
Fix incorrect platform detection in setenvvar.bat on VS2022#8866tomneko wants to merge 1 commit intoFirebirdSQL:B3_0_Releasefrom
tomneko wants to merge 1 commit intoFirebirdSQL:B3_0_Releasefrom
Conversation
hvlad
requested changes
Mar 20, 2026
|
|
||
| ::set FB_PROCESSOR_ARCHITECTURE=AMD64 | ||
| :: 1. Determine target platform | ||
| if "%Platform%"=="x86" set FB_TARGET_PLATFORM=Win32 |
Member
There was a problem hiding this comment.
I see this variable is defined by VS 2017 and VS 2022 and not defined by VS 2013.
Official compiler for FB3 is VS 2010.
Afraid this patch can be applied to the FB4+ only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes incorrect platform detection in
setenvvar.batwhenbuilding Firebird on modern Visual Studio environments (VS2022 Build Tools).
The current script relies on
PROCESSOR_ARCHITECTURE, which always reportsAMD64even when using the x86 Native Tools Command Prompt. As a result,FB_TARGET_PLATFORMis always set tox64, and Win32 builds do not behavecorrectly.
This patch replaces the detection logic with the
%Platform%variable, whichcorrectly reports
x86orx64depending on the toolchain.Fixes #8865